feat: display hostname in session header and sidebar#889
Open
jonocodes wants to merge 3 commits intoslopus:mainfrom
Open
feat: display hostname in session header and sidebar#889jonocodes wants to merge 3 commits intoslopus:mainfrom
jonocodes wants to merge 3 commits intoslopus:mainfrom
Conversation
- Add getMachineDisplayName() in new machineDisplay.ts utility - Pure function with no React dependencies, fully testable - Integrate hostname into SessionView subtitle - Format: hostname:~/path/to/dir - Respects Machine.displayName for custom names - 17 passing tests following existing patterns Closes slopus#870 🤖 Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
- Add hostname subtitle to active session rows in ActiveSessionsGroup - Update getSessionSubtitle to return "hostname:~/path" format - Consistent with hostname display already added to session header Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lute:~/projects/myapp)ActiveSessionsGroup)getSessionSubtitleto include hostname prefix for historical session items in the sidebarScreenshots
Before
After
Implementation
machineDisplay.ts— pure utility with no React dependencies, 17 passing testsgetMachineDisplayName()priority:Machine.displayName> short hostname >session.metadata.hostSessionView.tsx— hostname integrated into header subtitleActiveSessionsGroup.tsx— hostname subtitle line added toCompactSessionRowsessionUtils.ts—getSessionSubtitlenow returnshostname:~/pathformatTest plan
hostname:~/pathappears in the header subtitlehostname:~/path~/path)vitest run sources/utils/machineDisplay.spec.ts(17/17 passing)🤖 Generated with Claude Code