Fix markdown table parsing, selection, and empty cell rendering#893
Open
chaehyun2 wants to merge 2 commits intoslopus:mainfrom
Open
Fix markdown table parsing, selection, and empty cell rendering#893chaehyun2 wants to merge 2 commits intoslopus:mainfrom
chaehyun2 wants to merge 2 commits intoslopus:mainfrom
Conversation
- Preserve empty interior cells when parsing tables (fixes column misalignment when first header cell is empty) - Add selectable prop to table text elements (enables text selection and copy on web, matching other markdown blocks) Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
Empty cells had no text content causing lineHeight to not apply, resulting in cells ~1/3 the height of populated cells. Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filter(cell.length > 0)which dropped empty interior cells, causing column shift when the first header cell is empty. Now strips only leading/trailing|and preserves all cells.Textelements were missing theselectableprop, preventing copy & paste on web. All other markdown blocks already had this.lineHeightdidn't apply, making them ~1/3 the height of populated cells. AddedminHeight: 40to match expected cell height.Test plan
| | Col A | Col B |) — columns should align correctly🤖 Generated with Claude Code
via Happy