Fix/679 find journey by category attrs #695
Conversation
|
@jsuchal este treba v produkcii po mergnuti zbehnut toto:
chceme to ako migraciu este pridat do tohto PR alebo to vies nejako spustit rucne? |
crutch
force-pushed
the
fix/679-find-journey-by-category-attrs
branch
from
f7c162e to
bc0eb84
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| Document.where(searchable: steps).pluck(column).join(' ') | ||
| end | ||
|
|
||
| def categorization_search(*columns) |
There was a problem hiding this comment.
The method uses pluck(*columns) which could fail if no columns are passed. Consider adding a guard clause or default columns parameter.
| def categorization_search(*columns) | |
| def categorization_search(*columns) | |
| columns = [:name] if columns.empty? |
This allows journey to be found with keywords matching its categories.
crutch
force-pushed
the
fix/679-find-journey-by-category-attrs
branch
from
bc0eb84 to
e1d4e98
Compare
|
@crutch pridajme tu migraciu. |
|
@jsuchal pridal som |
| @@ -0,0 +1,67 @@ | |||
| // No-results analytics only | |||
There was a problem hiding this comment.
@crutch podla mna toto vyhodme zatial, vymyslime to inak. nechajme tu len ten search cez meno kategorie a to mergneme
closes #679