Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl: update MAINTAINERS.md per new Governance doc #1006

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

MarkLodato
Copy link
Member

  • Add a blurb at the top explaining what Maintainers are and linking to
    the Governance doc.
  • Add more explicit guidance on how to become a maintainer.
  • Link to the Governance doc for criteria for removal of a Maintainer,
    added in rewrite definition of Maintainer to be more precise governance#22.
  • Sort list of maintainers by first name (rather than last name) to make
    it easier to understand the order at a glance.
  • Rename "emeritus" to "retired", which is more descriptive.

Signed-off-by: Mark Lodato [email protected]

@MarkLodato MarkLodato requested review from kpk47 and lehors December 4, 2023 20:51
Copy link

netlify bot commented Dec 4, 2023

Deploy Preview for slsa canceled.

Name Link
🔨 Latest commit 5db1aff
🔍 Latest deploy log https://app.netlify.com/sites/slsa/deploys/656e3c487a337d0008bee704

- Add a blurb at the top explaining what Maintainers are and linking to
  the Governance doc.
- Add more explicit guidance on how to become a maintainer.
- Link to the Governance doc for criteria for removal of a Maintainer,
  added in slsa-framework/governance#22.
- Sort list of maintainers by first name (rather than last name) to make
  it easier to understand the order at a glance.
- Rename "emeritus" to "retired", which is more descriptive.

Signed-off-by: Mark Lodato <[email protected]>
@MarkLodato
Copy link
Member Author

I'll wait to submit this until slsa-framework/governance#22 is merged.

Copy link

@jkjell jkjell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mark! I really appreciate the phrasing around getting started and nominations.

Comment on lines +33 to +37
The best way to get started is to regularly contribute and review pull requests.

Emeritus maintainers have maintained the SLSA specification in the past but are
not currently doing so.
To nominate a candidate, send a PR adding the candidate's name to the list of
[Current Maintainers]. If the candidate is not the author, have the candidate
approve the PR as well.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@MarkLodato MarkLodato merged commit 4bd1a70 into slsa-framework:main Dec 7, 2023
5 checks passed
@MarkLodato MarkLodato deleted the maintainers branch December 7, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants