Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editorial: Separate producer from platform requirements in Levels #1009

Merged

Conversation

marcelamelara
Copy link
Contributor

@marcelamelara marcelamelara commented Dec 12, 2023

This PR adds a separate "Build Platform Requirements" row in each table of levels.md, more clearly defining what SW producers vs. build platform are responsible for at each level. To be clear, the requirements themselves have not changed, but rather the row in which they appear.

This change more closely matches the current separation in requirements.md, and also facilitates adding requirements for each role in higher/newer Build Track levels.

Copy link

netlify bot commented Dec 12, 2023

Deploy Preview for slsa ready!

Name Link
🔨 Latest commit da34f7b
🔍 Latest deploy log https://app.netlify.com/sites/slsa/deploys/659c3033c923f70009f9a346
😎 Deploy Preview https://deploy-preview-1009--slsa.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@marcelamelara
Copy link
Contributor Author

cc @joshuagl since I added this to the v1.1 directory (please let me know, if this shouldn't be part of those changes)

Copy link

@jkjell jkjell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the clarity this separation of responsibilities brings!

docs/spec/v1.1/levels.md Outdated Show resolved Hide resolved
docs/spec/v1.1/levels.md Outdated Show resolved Hide resolved
@marcelamelara marcelamelara force-pushed the separate-platform-requirements branch from 1699223 to 5a2e52f Compare December 19, 2023 00:16
docs/spec/v1.1/levels.md Outdated Show resolved Hide resolved
@marcelamelara marcelamelara force-pushed the separate-platform-requirements branch from 5a2e52f to 07e9d3a Compare December 19, 2023 17:30
docs/spec/v1.1/levels.md Outdated Show resolved Hide resolved
Co-authored-by: Andrew McNamara <[email protected]>
Signed-off-by: Marcela Melara <[email protected]>
@marcelamelara marcelamelara force-pushed the separate-platform-requirements branch from e973f1e to 5feb8e3 Compare January 6, 2024 00:22
Signed-off-by: Marcela Melara <[email protected]>
Copy link
Member

@joshuagl joshuagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like how this has turned out, thanks Marcela and all the reviewers for iterating on this!

docs/spec/v1.1/levels.md Outdated Show resolved Hide resolved
docs/spec/v1.1/levels.md Outdated Show resolved Hide resolved
Co-authored-by: Joshua Lock <[email protected]>
Signed-off-by: Marcela Melara <[email protected]>
@marcelamelara
Copy link
Contributor Author

The last set of recommended changes are in. Thank you all for the feedback!

@joshuagl joshuagl merged commit 6a8d9cb into slsa-framework:main Jan 9, 2024
6 checks passed
@marcelamelara marcelamelara deleted the separate-platform-requirements branch April 5, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants