impl: use consistent Markdown sytnax for tables #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Markdownlint table rules are falsely triggering in 0.39 because it doesn't understand liquid templates. Disable those rules for the liquid code to avoid lint errors. Signed-off-by: Mark Lodato <[email protected]>
This satisfies markdownlint-cli 0.39. Signed-off-by: Mark Lodato <[email protected]>
✅ Deploy Preview for slsa ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
1 task
joshuagl
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address markdownlint warning about inconsistent markdown syntax for
tables. We almost always use a trailing
|, so add that to the fewplaces where it's missing. Also disable the lint warning on Liquid
templates that markdownlint fails to parse properly.
This unblocks upgrading to markdownlint-cli v0.39 (#1021).
A future PR might switch to leading-only syntax (#1023), but that is
outside the scope of this PR.