Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl: use consistent "only-leading" table syntax #1025

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

MarkLodato
Copy link
Member

Fixes #1023 by using a consistent Markdown syntax for tables with a
leading | but no trailing trailing |. Change the markdown lint
config to require this in all files. Example:

| Key | Value
| --- | -----
| One | A
| Two | B

Fixes slsa-framework#1023 by using a consistent Markdown syntax for tables with a
leading `|` but no trailing trailing `|`. Change the markdown lint
config to require this in all files. Example:

```markdown
| Key | Value
| --- | -----
| One | A
| Two | B
```

Signed-off-by: Mark Lodato <[email protected]>
@MarkLodato MarkLodato requested a review from joshuagl February 6, 2024 21:35
Copy link

netlify bot commented Feb 6, 2024

Deploy Preview for slsa ready!

Name Link
🔨 Latest commit 1f855d2
🔍 Latest deploy log https://app.netlify.com/sites/slsa/deploys/65c2a642a443a7000820dd1b
😎 Deploy Preview https://deploy-preview-1025--slsa.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@joshuagl joshuagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick work on this one

@MarkLodato
Copy link
Member Author

I'll leave this open for a day or two in case anyone else wants to offer an opinion.

Copy link
Member

@lehors lehors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support this approach.
Thanks.

@MarkLodato MarkLodato merged commit 53992b6 into slsa-framework:main Feb 9, 2024
6 checks passed
@MarkLodato MarkLodato deleted the table-pipe-no-trailing branch February 9, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Markdown style for tables
3 participants