Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/nw23001440/ununderstable error #408

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Bugfix/nw23001440/ununderstable error #408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5649662
Add tests
lanarimarco Jan 31, 2024
5cf5475
Fix issue.
lanarimarco Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...Interpreter-core/src/main/kotlin/com/smeup/rpgparser/parsing/parsetreetoast/statements.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ internal fun BlockContext.toAst(conf: ToAstConfiguration = ToAstConfiguration())
this.begindow() != null -> this.begindow().toAst(blockContext = this, conf = conf)
this.forstatement() != null -> this.forstatement().toAst(conf)
this.begindou() != null -> this.begindou().toAst(blockContext = this, conf = conf)
else -> TODO(this.text.toString() + " " + toPosition(conf.considerPosition))
else -> todo(message = "Missing composite statement implementation for this block: ${this.text}", conf = conf)
}
}

Expand Down
14 changes: 14 additions & 0 deletions ...avaInterpreter-core/src/test/kotlin/com/smeup/rpgparser/interpreter/JarikoCallbackTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,16 @@ class JarikoCallbackTest : AbstractTest() {
executeSourceLineTest("ERROR10")
}

@Test
fun executeERROR11CallBackTest() {
executePgmCallBackTest("ERROR11", SourceReferenceType.Program, "ERROR11", listOf(5))
}

@Test
fun executeERROR11SourceLineTest() {
executeSourceLineTest("ERROR11")
}

/**
* This test simulates what a precompiler might do throws the use of the beforeParsing callback
* In ERROR01.rpgle I will comment C specification to avoid a division by zero errors
Expand Down Expand Up @@ -489,6 +499,10 @@ class JarikoCallbackTest : AbstractTest() {
}
}

/**
* Verify that the sourceLine is correctly set in case of error.
* ErrorEvent must contain a reference of an absolute line of the source code
* */
private fun executeSourceLineTest(pgm: String) {
lateinit var lines: List<String>
val errorEvents = mutableListOf<ErrorEvent>()
Expand Down
6 changes: 6 additions & 0 deletions rpgJavaInterpreter-core/src/test/resources/ERROR11.rpgle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
V* ==============================================================
D* Missing implementation of the DOWLE opcode
D*
V* ==============================================================
C $B DOWLE 13
C ENDDO
Loading