-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop before revert/LS25000520/Fix concurrence between DS and File #702
Merged
lanarimarco
merged 53 commits into
develop
from
develop_before_revert/LS25000142/fix-concurrence-between-ds-and-file
Feb 5, 2025
Merged
Develop before revert/LS25000520/Fix concurrence between DS and File #702
lanarimarco
merged 53 commits into
develop
from
develop_before_revert/LS25000142/fix-concurrence-between-ds-and-file
Feb 5, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hout specify the DS. There are two DS with same fields.
…nitions` if is declared a DS which uses `EXTNAME` to the same file
…declared as not `QUALIFIED`
…between-ds-and-file Bugfix/LS25000142/Fix concurrence between DS and File
…with the same logic
…shares same fields
lanarimarco
requested changes
Feb 5, 2025
rpgJavaInterpreter-core/src/test/kotlin/com/smeup/rpgparser/smeup/MULANGT02ConstAndDSpecTest.kt
Outdated
Show resolved
Hide resolved
lanarimarco
approved these changes
Feb 5, 2025
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This work is related to #696 . In addition:
removeFileFieldsDefinedInDs
has been removed because there is a new logic made from Bugfix/LS25000430/Concurrence between API definitions and fields of unnamed DS #700 withremoveStandaloneDefinedAsFieldOfUnqualifiedDs
;EXTNAME
is different fromF
spec but shares same fields.Related to #LS25000520
Checklist:
./gradlew ktlintCheck
)../gradlew check
).docs
directory.