Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/LS25000557/MOVEA from DS to S #703

Merged
merged 15 commits into from
Feb 7, 2025

Conversation

davidepalladino-apuliasoft
Copy link
Collaborator

Description

This work improves the MOVEA from DS to a S (not as number), like this snippet:

     D SCAATTDS        DS            10
     D SCAATT          S              1    DIM(10)
     ...
     C                   MOVEA     SCAATTDS      SCAATT 

Technical notes

On Jariko missed an implementation for takeFirst of DataStructValue. Finally, has been added an error (like on AS400) when the Result is a Standalone as number and not as string.

Related to #LS25000557

Checklist:

  • If this feature involves RPGLE fixes or improvements, they are well-described in the summary.
  • There are tests for this feature.
  • RPGLE code used for tests is easily understandable and includes comments that clarify the purpose of this feature.
  • The code follows Kotlin conventions (run ./gradlew ktlintCheck).
  • The code passes all tests (run ./gradlew check).
  • Relevant documentation is included in the docs directory.

@davidepalladino-apuliasoft davidepalladino-apuliasoft marked this pull request as ready for review February 6, 2025 09:21
@lanarimarco lanarimarco merged commit 46bde13 into develop Feb 7, 2025
1 check passed
@lanarimarco lanarimarco deleted the bugfix/LS25000557/movea-from-ds-to-s branch February 7, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants