fix(awsjson): URI Result not matched correctly#3530
Open
joostvdwsd wants to merge 7 commits intosmithy-lang:mainfrom
Open
fix(awsjson): URI Result not matched correctly#3530joostvdwsd wants to merge 7 commits intosmithy-lang:mainfrom
joostvdwsd wants to merge 7 commits intosmithy-lang:mainfrom
Conversation
rcoh
approved these changes
Apr 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
When trying out the AWS Json protocol I could not get a valid 200 result. After diving into the issue the awsjson router was not matching the url correctly when running from aws lambda.
The incomming request.uri() would result into "/?" instead of "/". This would always result in a mismatch.
Description
At this moment the fix is to use request.uri().path() != "/". This will result in correct behavior.
One downside of fixing it this way is that it will not be strict on requests against the root path with query params. It will allow any query param now.
Testing
Testing was now done on AWS lambda. No additional unit tests are created yet if the team finds this applicable..
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.