Add JSON serializer/deserializer implementation#4550
Draft
landonxjames wants to merge 11 commits intofeature/schemafrom
Draft
Add JSON serializer/deserializer implementation#4550landonxjames wants to merge 11 commits intofeature/schemafrom
landonxjames wants to merge 11 commits intofeature/schemafrom
Conversation
Also implemented container_size to pre-alloc containers
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Previously they were holding a Vec<u8> which required an extra alloc
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Adding JSON serde using the new Schema pattern. Also added serde for HTTP headers/query strings.
Testing
Many new unit tests for the serialization.
TODO: long term I would like to hook this up to the fuzzing that is already present in the
aws-smithy-jsoncrate, but in the interest of getting the POC done in a timely manner I'm putting that off for now.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.