Skip to content

Preact: properly extract targetRoomId from roomId in UserOptionsPanel #2568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zarel merged 3 commits into from
Mar 15, 2026
Merged

Preact: properly extract targetRoomId from roomId in UserOptionsPanel #2568

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5fc8366
Preact: properly extract targetRoomId from roomId in UserOptionsPanel
ISenseAura Dec 9, 2025
24e3f2a
remove unnecessary console.log
ISenseAura Dec 11, 2025
b89cfc3
Use PSUtils.splitFirst
Zarel Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion play.pokemonshowdown.com/src/panel-popups.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,8 @@ class UserOptionsPanel extends PSRoomPanel {
data?: Record<string, string>,
};
getTargets() {
const [, targetUser, targetRoomid] = this.props.room.id.split('-');
const [, targetUser, ...rest] = this.props.room.id.split('-');
const targetRoomid = rest.join('-');
Copy link
Copy Markdown
Member

@Zarel Zarel Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, isn't there Utils.splitFirst for this?

Image

Copy link
Copy Markdown
Member

@Zarel Zarel Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const [, targetUser, ...rest] = this.props.room.id.split('-');
const targetRoomid = rest.join('-');
const [, targetUser, targetRoomid] = PSUtils.splitFirst(this.props.room.id, '-', 2);

let targetRoom = (PS.rooms[targetRoomid] || null) as ChatRoom | null;
if (targetRoom?.type !== 'chat') targetRoom = targetRoom?.getParent() as ChatRoom;
if (targetRoom?.type !== 'chat') targetRoom = targetRoom?.getParent() as ChatRoom;
Expand Down