feat: add support for new skin logo in space settings #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pshot-labs/snapshot-sequencer into feat-add-logo-to-custom-skin
ChaituVR
requested changes
Feb 5, 2025
src/helpers/actions.ts
Outdated
| ]); | ||
|
|
||
| await addOrUpdateSkin(id, settings.skinParams); |
There was a problem hiding this comment.
Not sure if it is good to call addOrUpdateSkin inside addOrUpdateSpace, maybe we should just call it after addOrUpdateSpace everywhere
There was a problem hiding this comment.
addOrUpdateSkin is dependent of the addOrUpdateSpace, and will never be called without it. Why would making an extra call everywhere better ?
|
I ran this on prod DB and testnet DB ALTER TABLE skins
ADD COLUMN logo VARCHAR(256) DEFAULT NULL AFTER theme; |
wa0x6e
changed the base branch from
master
to
feat-update-space-skin-settings
Is the new column added to the table ? |
Yes ser #498 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toward https://github.com/snapshot-labs/workflow/issues/416
Depends on snapshot-labs/snapshot.js#1120
This PR adds support for saving and updating the logo passed in
skinParamsCreate the new required columns with