Fix: Pass api key in headers and detect html error #999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into fix-send-api-key-in-headers
…shot-labs/snapshot.js into fix-send-api-key-in-headers
wa0x6e
reviewed
May 17, 2024
wa0x6e
requested changes
May 17, 2024
| } catch (e) { | ||
| return Promise.reject({ | ||
| code: 500, | ||
| message: 'Failed to parse response from score API', |
There was a problem hiding this comment.
Same for message, I think it's available from res, so we could get something more descriptive like Network timeout
There was a problem hiding this comment.
Passing it in data param, as in this case error will be in HTML and can be unpredictable.if it is not HTML error we handle it seperately
Co-authored-by: Wan <[email protected]>
…shot-labs/snapshot.js into fix-send-api-key-in-headers
|
Just noticed that this issue may be fixed with #957, which goal is to hide the raw response, and convert it to a more concise one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
How to test:
testfolder, for examplevp.tswith the local score API server