Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change colnames of chromatogram() data.frame #305

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from

Conversation

jorainer
Copy link
Collaborator

- Change the column names of the `data.frame` returned by `chromatogram()` to
  `"rtime"` and `"intensity"` (issue sneumann#304).
@jorainer jorainer requested review from lgatto and sneumann January 29, 2025 10:48
@jorainer
Copy link
Collaborator Author

Added a quick additional change - chromatograms() was (silently) changing the result object type: is a single chromatogram was requested it returned a data.frame, if no chromatogram was specified, or multiple were requested it returned a list of data.frame. This causes some issues and additional checks in the Chromatograms package. I added now a new parameter drop = TRUE to the chromatograms() function that can be set to drop = FALSE so that always a list is returned (even for a single data.frame).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants