Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request timeout and timestamp as headers in HTTP target #396

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

pondzix
Copy link
Contributor

@pondzix pondzix commented Jan 29, 2025

PDP-1664

@pondzix pondzix force-pushed the http_target_new_headers branch 2 times, most recently from 859a301 to 6d51561 Compare January 29, 2025 17:10
@@ -66,6 +66,9 @@ target {
# Optional path to the file containing template which is used to build HTTP request based on a batch of input data
template_file = "myTemplate.file"

# Optional. When enabled, configured client timeout and timestamp of request are attached as HTTP headers.
include_timing_headers = true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is the best name...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't think of a better one 🤷

@pondzix pondzix requested a review from colmsnowplow January 29, 2025 17:11
Copy link
Collaborator

@colmsnowplow colmsnowplow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good stuff, thanks

@pondzix pondzix force-pushed the http_target_new_headers branch from 6d51561 to de34773 Compare January 31, 2025 07:52
@pondzix pondzix merged commit de34773 into develop Jan 31, 2025
1 check passed
@pondzix pondzix deleted the http_target_new_headers branch January 31, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants