Avoid installing types-requests at run-time
#370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowplowcla
added
the
cla:yes
edgarrmondragon
force-pushed
the
drop-types-requests
branch
from
f30557e to
2045564
Compare
edgarrmondragon
changed the title
types-requests at run-timetypes-requests at run-time
|
For extra context: this brings in an additional dependency (two if you count types-urllib3 for urllib3<2) at run-time, where it's not used and not needed. |
|
This is still needed :) Any progress? |
Just waiting for a maintainer to review :) |
|
Hey @edgarrmondragon, sorry for taking a while to get to this! Thanks for the PR, it looks good to me! I've merged this into release 1.1.0, so it should be out shorty 😄 |
Awesome, thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not required, so you could simply make it a dev dependency.