Fix for _schema_version overriding non-object entity data
#137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recommend that Snowplow entities should be JSON *objects* only. But technically it is possible for them to be something else, e.g. a JSON array. Since version 3.2.0 we started adding the `_schema_version` field to context entities, see #132. But this accidentally clobbered the original data if the entity was not an object. This commit fixes the problem by only adding `_schema_version` if the entity is an object.
benjben
approved these changes
Nov 6, 2024
istreeter
added a commit
that referenced
this pull request
Nov 6, 2024
We recommend that Snowplow entities should be JSON *objects* only. But technically it is possible for them to be something else, e.g. a JSON array. Since version 3.2.0 we started adding the `_schema_version` field to context entities, see #132. But this accidentally clobbered the original data if the entity was not an object. This commit fixes the problem by only adding `_schema_version` if the entity is an object.
istreeter
added a commit
to snowplow-incubator/common-streams
that referenced
this pull request
Nov 7, 2024
We recommend that Snowplow entities should be JSON *objects* only. But technically it is possible for them to be something else, e.g. a JSON array. Before this fix, we accidentally erased the original value if a context was not a JSON object. The fix was implented in snowplow/snowplow-scala-analytics-sdk#137 and is imported here.
istreeter
added a commit
to snowplow-incubator/common-streams
that referenced
this pull request
Nov 7, 2024
We recommend that Snowplow entities should be JSON *objects* only. But technically it is possible for them to be something else, e.g. a JSON array. Before this fix, we accidentally erased the original value if a context was not a JSON object. The bug only affected unstructed destinations, e.g. the Snowflake loader. The fix was implented in snowplow/snowplow-scala-analytics-sdk#137 and is imported here.
istreeter
added a commit
to snowplow-incubator/common-streams
that referenced
this pull request
Nov 7, 2024
We recommend that Snowplow entities should be JSON *objects* only. But technically it is possible for them to be something else, e.g. a JSON array. Before this fix, we accidentally erased the original value if a context was not a JSON object. The bug only affected unstructed destinations, e.g. the Snowflake loader. The fix was implented in snowplow/snowplow-scala-analytics-sdk#137 and is imported here.
istreeter
added a commit
to snowplow-incubator/common-streams
that referenced
this pull request
Nov 8, 2024
We recommend that Snowplow entities should be JSON *objects* only. But technically it is possible for them to be something else, e.g. a JSON array. Before this fix, we accidentally erased the original value if a context was not a JSON object. The bug only affected unstructed destinations, e.g. the Snowflake loader. The fix was implented in snowplow/snowplow-scala-analytics-sdk#137 and is imported here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ref: PDP-1523
We recommend that Snowplow entities should be JSON objects only. But technically it is possible for them to be something else, e.g. a JSON array.
Since version 3.2.0 we started adding the
_schema_versionfield to context entities, see #132. But this accidentally clobbered the original data if the entity was not an object. This commit fixes the problem by only adding_schema_versionif the entity is an object.