Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace orchestration APIs by test API #70

Merged
merged 80 commits into from
Jan 23, 2025

Conversation

PeterSchafer
Copy link
Contributor

@PeterSchafer PeterSchafer commented Jan 8, 2025

Description

This PR replaces the usage of lower level orchestration API by the usage of a higher level test API. The library interface doesn't change, only the implementation details are adapted.

This includes the preprocessing of the API specs and generating client code for the new API.
Currently the old API classes are still in the repo, removing them can be done in a second iteration.

Checklist

  • Tests added and all succeed
  • Linted
  • README.md updated, if user-facing

🚨After having merged, please update the snyk-ls and CLI go.mod to pull in latest client.

@PeterSchafer PeterSchafer changed the title Feat/cli 609 test api chore: replace orchestration APIs by test API Jan 23, 2025
@PeterSchafer PeterSchafer marked this pull request as ready for review January 23, 2025 16:00
@PeterSchafer PeterSchafer requested review from a team as code owners January 23, 2025 16:00
Copy link
Contributor

@bastiandoetsch bastiandoetsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Looking forward to the follow up pact tests.

@bastiandoetsch bastiandoetsch merged commit b513d7d into main Jan 23, 2025
12 checks passed
@bastiandoetsch bastiandoetsch deleted the feat/CLI-609_test_api branch January 23, 2025 16:06
@PeterSchafer PeterSchafer restored the feat/CLI-609_test_api branch January 23, 2025 17:00
@PeterSchafer PeterSchafer deleted the feat/CLI-609_test_api branch January 23, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants