Cli 609 pact testing test api #76
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandor-trombitas
force-pushed
the
CLI-609-pact-testing-test-api
branch
from
c7e2f2d to
1810658
Compare
|
|
||
| func createTestBody() (v20241221.CreateTestRequestBody, error) { | ||
| resultType := v20241221.CodeSecurity | ||
| body := v20241221.CreateTestRequestBody{ |
There was a problem hiding this comment.
Suggestion: Better use the existing helper to create a request rather than having this code bloating the test
| func TestTestClientPact(t *testing.T) { | ||
| setupPact(t) | ||
|
|
||
| t.Run("Create test", func(t *testing.T) { |
There was a problem hiding this comment.
Suggestion: These types of tests are highly beneficial for testing edge cases. Currently this only contains the happy path which is also already tested through User Journey tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide description of this PR and changes, if linked Jira ticket doesn't cover it in full.
Checklist
🚨After having merged, please update the
snyk-lsand CLI go.mod to pull in latest client.