-
Notifications
You must be signed in to change notification settings - Fork 35
fix: race condition for showing error in the tree view, remove notifi… #741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/IDE-1366_get-project-org-from-ls
Are you sure you want to change the base?
Conversation
…cation when Snyk Code isn't enabled for folder
|
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
| getSnykCachedResults(project)?.currentSnykCodeError != null -> { | ||
| val errorMessage = getSnykCachedResults(project)?.currentSnykCodeError?.message | ||
| val errorSuffix = when { | ||
| errorMessage?.contains("not enabled", ignoreCase = true) == true -> "(disabled at Snyk)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put the whole string or send another param from ls
| this.snykToolWindowPanel.displayScanningMessage() | ||
| } | ||
|
|
||
| this.snykToolWindowPanel.cleanUiAndCaches() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add TODO to clear cache per product
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do the changes in the comment, then it's good.
Oh, and update your PR title please.
33cfd9f to
94e374f
Compare
…cation when Snyk Code isn't enabled for folder

Description
Provide description of this PR and changes, if linked Jira ticket doesn't cover it in full.
Checklist
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!