-
Notifications
You must be signed in to change notification settings - Fork 12
feat: add code actions, fix ostest & feature flags [IDE-1493] #1054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bastiandoetsch
wants to merge
16
commits into
main
Choose a base branch
from
feat/IDE-1493_add-risk-score-and-fix-issues
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
19fd1c6 to
45337df
Compare
* test: seperate DIs for TestUnifiedTestApiSmokeTest Previously di.Init() was being called twice in the test. The test have been moved to sub-tests, this way each test only calls it once. * test: make test more robust * test: refactor out duplicate test logic * chore: add test generated files to .gitignore * test: make compare a smoke test Add more test failed to run diags
# Conflicts: # application/server/unified_test_api_smoke_test.go
# Conflicts: # application/server/server_smoke_test.go # infrastructure/oss/cli_scanner.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the OSS vulnerability processing and feature flag infrastructure, adds risk score display functionality, and improves code maintainability through better separation of concerns.
OSS Issue Processing Refactoring:
addCodeActionsAndLenses()helper function for better testability and reuseossIssueto standalone functions (GetExtendedMessage,createCveLink,createCweLink,createFixedIn,CreateIssueURL,GetCodeActions,AddSnykLearnAction,AddQuickFixAction) - removing tight coupling to the ossIssue structgetAffectedFilePath()helper to reduce code duplicationgetFileContent()into shared utility functionProcessScanResults()signature by using context for dependency injectionGetRemediation()- now only handles upgrade pathsRisk Score Feature (IDE-1493):
RiskScorefield toOssIssueDatastructdetails.html) to conditionally display risk score when non-zeroUseExperimentalRiskScoreandUseExperimentalRiskScoreInCLIto control risk score functionalityFeature Flag Infrastructure Overhaul:
map[string]withimcache.Cachefor both feature flags and SAST settings storageWithProvider()option for cleaner dependency injection and improved testabilityPopulateFolderConfig()now automatically persists folder config viastoredconfig.UpdateFolderConfig()New()constructor with optionsTest Infrastructure Improvements:
Code + Rangeas matching key instead of relying on OssIssueData internal fieldsOther Changes:
Files Changed: 26 files (+549/-588 lines)
Checklist
make generate)make lint-fix)