-
Notifications
You must be signed in to change notification settings - Fork 32
feat: read inline ignore ff from folder config #679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Summary of ChangesHello @nick-y-snyk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements the ability to read and apply the 'inline ignore' feature flag for Snyk Code based on individual folder configurations. This change moves the control of this feature from a global setting to a more localized, folder-specific one, providing greater flexibility for users. The modifications involve updating data structures to include feature flags in folder configurations, adjusting service constructors to pass these configurations, and refining the logic that determines when the inline ignore functionality is available. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the handling of the snykCodeInlineIgnore feature flag to be folder-specific. The flag is now read from the folderConfig, which allows for more granular control over this feature in multi-root workspaces.
The changes involve:
- Adding a
featureFlagsproperty to theFolderConfigtype. - Plumbing the
folderConfigsservice down toSnykCodeActionsProvider. - Updating
SnykCodeActionsProviderto check the per-folder feature flag before adding ignore-related code actions. - Removing the now-redundant feature flag check from the
CodeSuggestionWebviewProvider, presumably because this logic is now handled by the Language Server which generates the webview content. - Updating unit tests to reflect these changes, including tests for both enabled and disabled states of the feature flag.
The implementation is clean and the changes are consistent across the codebase. The updated tests provide good coverage for the new logic. Overall, this is a solid improvement.
rrama
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just fix the lint issues.
| codeActionKindAdapter: ICodeActionKindAdapter, | ||
| private readonly languages: IVSCodeLanguages, | ||
| private readonly configuration: IConfiguration, | ||
| private readonly folderConfigs: IFolderConfigs, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, this would not change if LS changes the value, but since we are only using it for the code action, good enough.
In the other PR branch you could have got it from the configuration, but this is fine.
|
|
||
| private mapToModel(issue: Issue<CodeIssueData>): Suggestion { | ||
| const parsedDetails = marked.parse(issue.additionalData.text) as string; | ||
| const showInlineIgnoresButton = configuration.getFeatureFlag(FEATURE_FLAGS.snykCodeInlineIgnore); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like the linter says. Please remove unused imports.
2a4edaa to
81c8d8e
Compare
Description
Provide description of this PR and changes, if linked Jira ticket doesn't cover it in full.
Checklist
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!