[Sofa.Simulation.Graph] Remove DAGSimulation and DAGNode#5610
Open
damienmarchal wants to merge 46 commits into
Open
[Sofa.Simulation.Graph] Remove DAGSimulation and DAGNode#5610damienmarchal wants to merge 46 commits into
damienmarchal wants to merge 46 commits into
Conversation
damienmarchal
added
pr: status to review
…ulation.cpp Not perfect but much better. Next step is to remove the singleton.
Contributor
|
[ci-build][with-all-tests][force-full-build] |
Collaborator
|
[ci-depends-on] detected during build #4. To unlock the merge button, you must
|
damienmarchal
added
pr: status wip
Important things are: - integration of NODEgetMeshTopologyLink into getMeshTopologyLink - refactoring of updateContext, updateVisualContext and updateSimulationContext Some code was shared between them.. so I factorize that into a new method called initializeContexts() non important things are removal of un-needed static_cast<Node*>
Collaborator
|
[ci-depends-on] detected during build #19. All dependencies are merged/closed. Congrats! 👍 |
Contributor
|
There are still some tests failing |
Collaborator
|
[ci-depends-on] detected during build #20. All dependencies are merged/closed. Congrats! 👍 |
damienmarchal
added
pr: status wip
Collaborator
|
[ci-depends-on] detected during build #21. All dependencies are merged/closed. Congrats! 👍 |
damienmarchal
added
pr: status to review
Collaborator
|
[ci-depends-on] detected during build #22. All dependencies are merged/closed. Congrats! 👍 |
Collaborator
|
[ci-depends-on] detected during build #23. All dependencies are merged/closed. Congrats! 👍 |
Contributor
|
The CI shows tests failing: https://www.sofa-framework.org/dash/?branch=origin/PR-5610 @damienmarchal |
hugtalbot
added
pr: status wip
There was no method to get the PathName() to a BaseData only a linkpath (so with the "@" prefix indicating a link). I add the missing feature and make some minor cleaning
…lation # Conflicts: # Sofa/framework/Core/src/sofa/core/objectmodel/BaseData.cpp # Sofa/framework/Core/src/sofa/core/objectmodel/BaseObject.cpp
damienmarchal
added
pr: status to review
Collaborator
|
[ci-depends-on] detected during build #24. All dependencies are merged/closed. Congrats! 👍 |
hugtalbot
added
pr: status wip
Contributor
|
CI is failing, to test the PR do not hesitate to use the "ci-build" keyword ;) |
Contributor
Author
|
@hugtalbot Are you sure that [ci-build] works with pr-wip, ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up discussions in this issue: #5556
The PR is based on: #5566
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if