Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/syn to lock #1382

Closed
wants to merge 4 commits into from
Closed

Conversation

Lo1nt
Copy link
Collaborator

@Lo1nt Lo1nt commented Dec 22, 2023

Motivation:

refactor synchronized to Lock to adapt to virtual thread

Modification:

Result:

@sofastack-cla sofastack-cla bot added cla:yes CLA is ok size/M labels Dec 22, 2023
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (1e99afb) 72.01% compared to head (f9e3206) 72.03%.

Files Patch % Lines
.../sofa/rpc/dynamic/DynamicConfigManagerFactory.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1382      +/-   ##
============================================
+ Coverage     72.01%   72.03%   +0.01%     
  Complexity      784      784              
============================================
  Files           416      416              
  Lines         17661    17673      +12     
  Branches       2752     2752              
============================================
+ Hits          12719    12730      +11     
- Misses         3538     3540       +2     
+ Partials       1404     1403       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lo1nt Lo1nt added this to the 5.12.0 milestone Dec 26, 2023
@Lo1nt Lo1nt closed this Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant