Fix cypress index test broken by #484's truncate wrapper - #510
Merged
Conversation
packages/cli/cypress/e2e/index.cy.js had the same brittle
cy.contains("preview")/("Emails") assertions that #508 fixed in the e2e
copy, but this repo-level copy was missed — so #484's truncate <div> made
cy.contains match the wrapper (no role/aria-expanded) and the "cypress"
workflow failed. Scope to cy.contains('[role="treeitem"]', ...) like #508.
Also drop a stray unused `require("typescript")` at the top of the file.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
packages/cli/cypress/e2e/index.cy.js(the repo-level cypress spec) had the same brittlecy.contains("preview")/cy.contains("Emails")assertions that #508 hardened in the e2e copy — but this file was missed. #484's truncate<div>wrapper makescy.containsmatch the wrapper (which lacksrole/aria-expanded), so the cypress workflow started failing on main.Scopes the assertions to
cy.contains('[role="treeitem"]', ...)(same fix as #508) and drops a stray unusedrequire("typescript"). Test-only — no published code changes, so no re-release needed.