target binary by name (for upcoming release) #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
issues like #19 and softprops/lambda-rust#2 have indicated that assumptions about using a find command in a container to discover executables on window os'es can be problematic even with docker.
as an alternative strategy we can leverage this plugins knowledge of the binary name to provide an explicit hint to the containerized builder which binary to package. this is just a prep pr pending the release of the next version of lambda-rust which will include a hook to take advantage of that hook.
Closes: #xxx
How did you verify your change:
What (if anything) would need to be called out in the CHANGELOG for the next release: