Store plugins in the Crate structure #209
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
integraledelebesgue
requested review from
Arcticae and
Draggu
and removed request for
a team
This was referenced Jan 21, 2025
Draggu
reviewed
Jan 21, 2025
integraledelebesgue
force-pushed
the
spr/main/fa144cb1
branch
from
eb2d8ce to
659c827
Compare
integraledelebesgue
force-pushed
the
spr/main/988401af
branch
from
5a57025 to
9942c29
Compare
integraledelebesgue
force-pushed
the
spr/main/fa144cb1
branch
from
659c827 to
a1a6506
Compare
integraledelebesgue
force-pushed
the
spr/main/988401af
branch
3 times, most recently
from
b7e504f to
456121c
Compare
integraledelebesgue
force-pushed
the
spr/main/fa144cb1
branch
from
639396f to
98cc352
Compare
integraledelebesgue
force-pushed
the
spr/main/988401af
branch
from
456121c to
29698c0
Compare
integraledelebesgue
force-pushed
the
spr/main/fa144cb1
branch
from
98cc352 to
321bd50
Compare
piotmag769
requested changes
Jan 23, 2025
integraledelebesgue
force-pushed
the
spr/main/988401af
branch
from
29698c0 to
ff0fc4d
Compare
integraledelebesgue
force-pushed
the
spr/main/fa144cb1
branch
from
321bd50 to
c43464a
Compare
integraledelebesgue
force-pushed
the
spr/main/988401af
branch
from
ff0fc4d to
8364856
Compare
integraledelebesgue
force-pushed
the
spr/main/fa144cb1
branch
from
c43464a to
c161fce
Compare
integraledelebesgue
force-pushed
the
spr/main/988401af
branch
2 times, most recently
from
67150c9 to
2a85ae2
Compare
piotmag769
reviewed
Jan 29, 2025
mkaput
reviewed
Jan 30, 2025
| use cairo_lang_utils::{Intern, LookupIntern}; | ||
| use smol_str::SmolStr; | ||
|
|
||
| use crate::lang::db::AnalysisDatabase; | ||
|
|
||
| /// A complete set of information needed to set up a real crate in the analysis database. | ||
| #[derive(Debug, PartialEq, Eq)] | ||
| #[derive(Debug)] |
There was a problem hiding this comment.
I would like to preserve the plain nature of this struct. I know we're not based on upstream changes to the compiler yet here, but do you think if it would be possible to keep just a set of plugin ids here?
There was a problem hiding this comment.
You don't have plugin ids in this PR at all since they are never interned, only treated as an input
There was a problem hiding this comment.
Storing IDs in Crate seems possible when we start using the new compiler API, but it would require passing a database to extract_crates, which can be tricky
There was a problem hiding this comment.
@piotmag769 is right. we would need to have a custom ID mechanism (PackageIDs I guess) at this stage. nonetheless, this is a separate piece of work which is not needed urgently right now
integraledelebesgue
force-pushed
the
spr/main/fa144cb1
branch
from
48c6c86 to
c90354f
Compare
integraledelebesgue
force-pushed
the
spr/main/988401af
branch
2 times, most recently
from
575ba49 to
703c3ee
Compare
integraledelebesgue
force-pushed
the
spr/main/fa144cb1
branch
from
c90354f to
30755d0
Compare
integraledelebesgue
force-pushed
the
spr/main/fa144cb1
branch
from
30755d0 to
9bc35f1
Compare
integraledelebesgue
force-pushed
the
spr/main/988401af
branch
from
703c3ee to
4ab2c0a
Compare
commit-id:988401af
integraledelebesgue
force-pushed
the
spr/main/988401af
branch
from
4ab2c0a to
8eeba76
Compare
piotmag769
approved these changes
Feb 10, 2025
piotmag769
reviewed
Feb 10, 2025
| Some(builtin_plugin.suite()) | ||
| }) | ||
| .fold( | ||
| get_default_plugin_suite(), // All crates have basic plugins set by default. |
There was a problem hiding this comment.
You need to add tricks here too :c
|
|
||
| /// Built-in plugins required by the crate. | ||
| #[allow(dead_code)] // TODO: remove. The field is used later in the stack | ||
| pub builtin_plugins: PluginSuite, |
There was a problem hiding this comment.
We probably want to expose them in ViewAnalyzedCrates (the names of builtin plugins that were loaded), wdyt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack: