Skip to content

feat: add C++ JSI interface and Executorch dependency #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: v0.4.0-rc1
Choose a base branch
from

Conversation

JakubGonera
Copy link
Contributor

@JakubGonera JakubGonera commented Apr 11, 2025

Description

Add C++ JSI interface and Executorch dependency for Android and iOS.

For Android:

  • Add CMake integration for building C++ code.
  • Add JSI installer that is called from Kotlin via JNI.
  • Add Executorch C++ dependency by a dynamic library extracted from the .aar provided by an Executorch script.

For iOS:

  • Add JSI installer in Objective C++.
  • Modify the podspec to statically link Executorch. The binaries are extracted from the xcframeworks provided by an Executorch script.

Files in common/ are included automatically for Android, for iOS add a reference to them in Xcode.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improves or adds clarity to existing documentation)

Tested on

  • iOS
  • Android

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings

@JakubGonera JakubGonera changed the base branch from main to v0.4.0-rc1 April 11, 2025 13:44
@JakubGonera JakubGonera marked this pull request as ready for review April 11, 2025 13:47
@JakubGonera JakubGonera changed the title feat: Add C++ JSI interface and Executorch dependency feat: add C++ JSI interface and Executorch dependency Apr 11, 2025
@msluszniak
Copy link
Member

C++ part looks good :))

@JakubGonera JakubGonera linked an issue May 7, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable native C++ and port current functionalities
5 participants