-
Notifications
You must be signed in to change notification settings - Fork 30
feat: add C++ JSI interface and Executorch dependency #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JakubGonera
wants to merge
11
commits into
v0.4.0-rc1
Choose a base branch
from
@jakubgonera/cpp
base: v0.4.0-rc1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cd77581
to
673d4e1
Compare
chmjkb
requested changes
Apr 14, 2025
C++ part looks good :)) |
3b1a542
to
4ad408b
Compare
304f24d
to
08b71a8
Compare
mkopcins
requested changes
May 14, 2025
mkopcins
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add C++ JSI interface and Executorch dependency for Android and iOS.
For Android:
For iOS:
Files in common/ are included automatically for Android, for iOS add a reference to them in Xcode.
Type of change
Tested on
Checklist