-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add 0.78.0-rc.3 support #6934
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4add399
to
57653bb
Compare
As we discussed with @tomekzaw, we now use if/else macros to support RN 0.78 and will get rid of them when all problematic deps of our example apps can be bumped to 0.78 as well. |
MatiPl01
commented
Feb 4, 2025
...ges/react-native-reanimated/Common/cpp/reanimated/LayoutAnimations/LayoutAnimationsProxy.cpp
Show resolved
Hide resolved
tomekzaw
approved these changes
Feb 4, 2025
This was referenced Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds if checks for the RN 0.78 in native code, thanks to which package builds on both - 0.78 nd 0.77.
Checklist
react-native-screens
when 0.78 support is added (feat: support for RN 0.78.0-rc.5 react-native-screens#2626)react-native-svg
when 0.78 support is added (feat: support [email protected] react-native-svg#2619)react-native-gesture-handler
when 0.78 support is added (Support React Native 0.78 react-native-gesture-handler#3354)react-native-pager-view
auto generated schema contains invalidStringEnumTypeAnnotation
fields and crashes build on Android*Apps where RN was upgraded don't run because of incompatible dependency versions