Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow TypedData revision 1 #1360

Merged
merged 58 commits into from
Jun 24, 2024
Merged

Conversation

franciszekjob
Copy link
Collaborator

@franciszekjob franciszekjob commented Jun 14, 2024

Relates #1353

Introduced changes

Basic support for revision 1 TypedData, featured in SNIP-12. Full support for SNIP-12 and both revision 0 and 1 basic/preset types and types verification will be added in separate PRs.

  • This PR contains breaking changes
  • StarkNetDomain is renamed to Domain
  • TypedData.domain is now an instance of Domain dataclass instead of a dict

@franciszekjob franciszekjob marked this pull request as ready for review June 17, 2024 11:33
@franciszekjob franciszekjob changed the title Franciszekjob/1353 snip 12 Allow TypedData revision 1 Jun 17, 2024
@franciszekjob franciszekjob requested a review from ddoktorski June 17, 2024 12:09
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 5 lines in your changes missing coverage. Please review.

Project coverage is 87.80%. Comparing base (345b0ba) to head (e158122).
Report is 1 commits behind head on development.

Additional details and impacted files
@@               Coverage Diff               @@
##           development    #1360      +/-   ##
===============================================
- Coverage        96.97%   87.80%   -9.18%     
===============================================
  Files               93       97       +4     
  Lines             4766     4888     +122     
===============================================
- Hits              4622     4292     -330     
- Misses             144      596     +452     
Files Coverage Δ
starknet_py/net/models/typed_data.py 100.00% <100.00%> (ø)
starknet_py/hash/hash_method.py 92.30% <92.30%> (ø)
starknet_py/net/schemas/common.py 75.69% <90.00%> (-10.88%) ⬇️
starknet_py/utils/typed_data.py 93.70% <94.91%> (-5.22%) ⬇️

... and 55 files with indirect coverage changes

Copy link
Collaborator

@ddoktorski ddoktorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the migration guide with all the breaking changes. It can done in a separate PR.

@franciszekjob franciszekjob requested a review from ddoktorski June 21, 2024 15:46
@franciszekjob franciszekjob requested a review from ddoktorski June 24, 2024 14:06
@franciszekjob franciszekjob requested a review from ddoktorski June 24, 2024 14:41
@franciszekjob franciszekjob merged commit 8ce7035 into development Jun 24, 2024
16 checks passed
@franciszekjob franciszekjob deleted the franciszekjob/1353-snip-12 branch June 24, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants