-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow TypedData
revision 1
#1360
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #1360 +/- ##
===============================================
- Coverage 96.97% 87.80% -9.18%
===============================================
Files 93 97 +4
Lines 4766 4888 +122
===============================================
- Hits 4622 4292 -330
- Misses 144 596 +452
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also update the migration guide with all the breaking changes. It can done in a separate PR.
…nDict.chainId' type to `str`
Co-authored-by: ddoktorski <[email protected]>
Co-authored-by: ddoktorski <[email protected]>
Relates #1353
Introduced changes
Basic support for revision 1
TypedData
, featured in SNIP-12. Full support for SNIP-12 and both revision 0 and 1 basic/preset types and types verification will be added in separate PRs.Revision
StarkNetDomain
toDomain
Domain.revision
field; Allow revision 1 to be an integer, ref: Adding notes on revision 1 type and value mismatch starknet-io/SNIPs#79HashMethod
StarkNetDomain
is renamed toDomain
TypedData.domain
is now an instance ofDomain
dataclass instead of a dict