fix: write anchor expand output to stdout#4269
Open
Nicknamess96 wants to merge 1 commit intosolana-foundation:masterfrom
Open
fix: write anchor expand output to stdout#4269Nicknamess96 wants to merge 1 commit intosolana-foundation:masterfrom
Nicknamess96 wants to merge 1 commit intosolana-foundation:masterfrom
Conversation
`anchor expand` previously saved the macro-expanded source to a timestamped file under `.anchor/expanded-macros/` and printed the path. This made it impossible to pipe the output into other tools. Write the expanded source directly to stdout instead, so callers can use standard shell redirection (`> file.rs`) or pipe it through formatters and pagers. The `chrono` dependency is dropped since timestamps are no longer needed for the file name. Closes solana-foundation#4267
|
@Nicknamess96 is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
jamie-osec
reviewed
Mar 2, 2026
Comment on lines
1668
to
1669
| .stderr(Stdio::inherit()) | ||
| .output() |
Collaborator
There was a problem hiding this comment.
We can just pipe stderr straight to our own stdout
Suggested change
| .stdout(std::process::Stdio::null()) | |
| .stderr(std::io::stdout()) | |
| .status() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`anchor expand` saves the macro-expanded source to a timestamped file
under `.anchor/expanded-macros/` and prints the path, which makes it
impossible to pipe the output into other tools.
This patch writes the expanded source directly to stdout so callers can
redirect it (`> file.rs`) or pipe it through formatters and pagers like
any other CLI tool.
The now-unused `chrono` dependency is also removed.
Closes #4267