idl: Make serde_json optional#4296
Merged
acheroncrypto merged 3 commits intosolana-foundation:masterfrom Mar 10, 2026
Merged
Conversation
|
@acheroncrypto is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
acheroncrypto
added
dependencies
jamie-osec
reviewed
Mar 9, 2026
jamie-osec
reviewed
Mar 9, 2026
Co-authored-by: Jamie Hill-Daniel <134328753+jamie-osec@users.noreply.github.com>
jamie-osec
approved these changes
Mar 9, 2026
0x4ka5h
approved these changes
Mar 10, 2026
acheroncrypto
merged commit f0d7b49
into
solana-foundation:master
114 of 116 checks passed
github-project-automation
bot
moved this from Security Review Required
to Done
in Anchor 1.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
serde_jsondependency is not necessary for the default features of the IDL crate.Summary of changes
Make the
serde_jsondependency optional and enable it for thebuildandconvertfeatures.Note:
anyhowandserdealso don't seem necessary, but the spec crate, which is exported astypesfrom the main IDL crate, uses them, meaning it's functionally useless to make them optional in the main crate.