Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

token-js: add derivation of createAssociatedTokenAccountIdempotentInstruction #7183

Merged
merged 6 commits into from
Aug 23, 2024
Merged

token-js: add derivation of createAssociatedTokenAccountIdempotentInstruction #7183

merged 6 commits into from
Aug 23, 2024

Conversation

zzau13
Copy link
Contributor

@zzau13 zzau13 commented Aug 22, 2024

Fixes #7178

@mergify mergify bot added the community Community contribution label Aug 22, 2024
joncinque
joncinque reviewed Aug 23, 2024
View reviewed changes
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! All of the code changes look good, I just have a question on the comment that was added

joncinque
joncinque approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@joncinque joncinque merged commit ab9fa9a into solana-labs:master Aug 23, 2024
17 checks passed
@joncinque joncinque changed the title add derivation of createAssociatedTokenAccountIdempotentInstruction token-js: add derivation of createAssociatedTokenAccountIdempotentInstruction Aug 23, 2024
@zzau13 zzau13 deleted the 7178 branch August 23, 2024 16:35
@Herychukwu Herychukwu mentioned this pull request Aug 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joncinque joncinque joncinque approved these changes

Assignees
No one assigned
Labels
community Community contribution
Projects
None yet
Milestone
No milestone
2 participants
@zzau13 @joncinque