-
Notifications
You must be signed in to change notification settings - Fork 938
Conversation
… after they release the patch
I'm going to presume we can preemptively allowlist |
Automerge label removed due to a CI failure |
Didn't work on mine either, weird. |
Well, it depends on what you mean by ‘work.’ The engines thing doesn't affect this, I don't think: solana-web3.js/.github/workflows/pull-requests.yml Lines 60 to 63 in 94b4d49
That's the only thing that will fix CI. The |
I wouldn't worry about it too much. Let's just let them ship nodejs/node#49528. |
perhaps temporarily remove the rule where a failure on node current aborts the run on node lts? assuming this is trivial anyway |
This does sound more logical ha |
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
I spotted this in one of the PRs linked in nodejs/node#49497 .
It should solve our CI problem until the issue is resolved (?).