-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BrAPI: set default germplasm acquisitionDate and use in filtering #5304
Conversation
sgn-405.0 make_release_tag: tagging master as release sgn-405.0
if 'acquitision date' stock prop is present, use that instead of the create_date
… in Germplasm search
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not clear how the search works with acquisition_date, as it is just a match and not a smaller or larger than comparison
@lukasmueller |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:-)
Description
This adds more support for the
acquisitionDate
germplasm property in BrAPI endpoints:acquisitionDate
property will use theacquisition date
stock property if it was manually added for a particular accession. When this is NOT present, it will use the stockcreate_date
field (automatically set when a stock is added to the database) for theacquisitionDate
. This ensures that every stock will have anacquisitionDate
set (either thecreate_date
by default or theacquisition date
stock property, if set).GET
/germplasm
andPOST
/search/germplasm
BrAPI endpoints:acquisitionDate
- filter germplasm for an exact acquisition dateminAcquisitionDate
- filter germplasm that have an acquisition date >= the param valuemaxAcquisitionDate
- filter germplasm that have an acquisition date <= the param valueFixes #5303
Related to plantbreeding/BrAPI#624
Checklist
/t/data/fixture/patches/
./docs
has been updated./js
to/js/source/legacy
.