Should skip install update (#10568)

solo-io · Jan 13, 2025 · 7d09cd7 · 7d09cd7
1 parent 898a84f
commit 7d09cd7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/changelog/v1.19.0-beta3/ShouldSkipInstall-update.yaml b/changelog/v1.19.0-beta3/ShouldSkipInstall-update.yaml
@@ -0,0 +1,6 @@
+changelog:
+  - type: FIX
+    issueLink: https://github.com/solo-io/solo-projects/issues/7432
+    resolvesIssue: false
+    description: >-
+      Export IsGatewayInstalled for use in other packages
diff --git a/test/kubernetes/e2e/test.go b/test/kubernetes/e2e/test.go
@@ -197,13 +197,13 @@ func (i *TestInstallation) InstallGlooGatewayWithTestHelper(ctx context.Context,
 	i.InstallGlooGateway(ctx, installFn)
 }
 
-func (i *TestInstallation) isGatewayInstalled(ctx context.Context) bool {
+func (i *TestInstallation) IsGatewayInstalled(ctx context.Context) bool {
 	return i.Assertions.CheckResourcesOk(ctx) == nil
 }
 
 func (i *TestInstallation) InstallGlooGateway(ctx context.Context, installFn func(ctx context.Context) error) {
 
-	if !testutils.ShouldSkipInstall(i.isGatewayInstalled(ctx)) {
+	if !testutils.ShouldSkipInstall(i.IsGatewayInstalled(ctx)) {
 		err := installFn(ctx)
 		i.Assertions.Require.NoError(err)
 		i.Assertions.EventuallyInstallationSucceeded(ctx)