Skip to content

Commit

Permalink
PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
arianaw66 committed Nov 15, 2024
1 parent 28a4d37 commit de8fbe6
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
4 changes: 3 additions & 1 deletion devel/testing/kube-e2e-tests.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,6 @@ These tests are run by a [GitHub action](/.github/workflows/regression-tests.yam
If a test fails, you can retry it from a [browser window](https://docs.github.com/en/actions/managing-workflow-runs/re-running-workflows-and-jobs#reviewing-previous-workflow-runs). If you do this, please make sure to comment on the Pull Request with a link to the failed logs for debugging purposes.

## Local Development
See the [kube2e test README](/test/kube2e/README.md) for more details about running these tests.
See the [kubernetes e2e test README](/test/kubernetes/e2e/README.md) and [debugging guide](/test/kubernetes/e2e/debugging.md) for more details about running these tests.

See the [kube2e test README](/test/kube2e/README.md) for more details about running the legacy tests.
10 changes: 10 additions & 0 deletions install/helm/gloo/crds/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
The CRDs in this directory are partially generated by solo-kit.
That implementation is explained [here](https://github.com/solo-io/solo-kit/tree/main/pkg/code-generator/schemagen#implementation).

It is worth noting that solo-kit only generates the schemas for these CRDs.
Other spec fields such as the `categories` can be updated manually.

Gloo Gateway CRD `categories`:
- All Gloo Gateway CRDs should include the "gloo-gateway" category.
- Any Gloo Gateway CRDs which are only used by enterprise customers should additionally include the "solo-io" category.
- Currently, these are the AuthConfig, RateLimitConfig, and GraphQLApi CRDs.

0 comments on commit de8fbe6

Please sign in to comment.