gateway2: reconcile on HTTPRoute annotation change (#10522)

Signed-off-by: Shashank Ram <[email protected]>
solo-io · Dec 19, 2024 · f596af6 · f596af6
1 parent 6c6f272
commit f596af6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/changelog/v1.18.2/httproute-annotation.yaml b/changelog/v1.18.2/httproute-annotation.yaml
@@ -0,0 +1,7 @@
+changelog:
+  - type: FIX
+    issueLink: https://github.com/solo-io/solo-projects/issues/7514
+    resolvesIssue: false
+    description: |
+      Route delegation makes use of delegation.gateway.solo.io/*
+      annotations, so changes to annotations should reconcile HTTPRoutes.
diff --git a/projects/gateway2/controller/controller.go b/projects/gateway2/controller/controller.go
@@ -311,7 +311,7 @@ func (c *controllerBuilder) watchCustomResourceDefinitions(_ context.Context) er
 
 func (c *controllerBuilder) watchHttpRoute(_ context.Context) error {
 	return ctrl.NewControllerManagedBy(c.cfg.Mgr).
-		WithEventFilter(predicate.GenerationChangedPredicate{}).
+		WithEventFilter(predicate.Or(predicate.GenerationChangedPredicate{}, predicate.AnnotationChangedPredicate{})).
 		For(&apiv1.HTTPRoute{}).
 		Complete(reconcile.Func(c.reconciler.ReconcileHttpRoutes))
 }