Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.trivyignore: ignore cve #10393

Merged
merged 5 commits into from
Nov 22, 2024
Merged

.trivyignore: ignore cve #10393

merged 5 commits into from
Nov 22, 2024

Conversation

sam-heilbron
Copy link

@sam-heilbron sam-heilbron commented Nov 22, 2024

Description

Update .trivyignore contents

Context

https://github.com/solo-io/solo-projects/issues/7157#issuecomment-2463252858

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@solo-changelog-bot
Copy link

Issues linked to changelog:
https://github.com/solo-io/solo-projects/issues/7157

@sam-heilbron
Copy link
Author

/skip-ci no functional changes

@sam-heilbron sam-heilbron requested a review from nfuden November 22, 2024 01:20
# https://github.com/advisories/GHSA-5fhx-39r8-3jwh
# This is resolved in versions of Gloo Gateway that rely on Go1.22 and above (1.17, 1.18)
# For ealier versions of Gloo Gateway, we confirmed that the vulnerability is not exploitable
# and captured our findings here: https://github.com/solo-io/solo-projects/issues/7157#issuecomment-2463252858
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: ideally shouldn't link to a private repo

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, though it holds all the details so I wanted to make sure it was discoverable. Do you think we have an alternative?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe if we had a public GH issue. but i'm fine with this for now

@sam-heilbron
Copy link
Author

I encountered a test flake and created kgateway-dev#10375

@soloio-bulldozer soloio-bulldozer bot merged commit a36c350 into main Nov 22, 2024
17 of 18 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the sh/trivy-ignore branch November 22, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants