-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Match Conditions to the validation webhook #10554
Conversation
Issues linked to changelog: |
635a934
to
b765bcf
Compare
Visit the preview URL for this PR (updated for commit 4aa522e): https://gloo-edge--pr10554-match-conditions-smxvgur6.web.app (expires Sat, 18 Jan 2025 04:23:47 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Nathan Fudenberg <[email protected]>
Description
Adds support for match conditions (defined via Common Expression Language (CEL)) to the validating webhook to allow fine grained request filtering. They can be set via two new helm values :
gateway.validation.matchConditions
on the Gloo webhookgateway.validation.kubeCoreMatchConditions
on the Kube webhookAPI changes
Added the following helm values :
gateway.validation.matchConditions
gateway.validation.kubeCoreMatchConditions
Context
This feature is useful when the webhook failure policy needs to be Fail but excludes certain resources from validation so an unreachable gloo pod does not block resource deletion
Eg: The user wants to exclude validation of secrets or resources with the foo label :
Testing steps
Added kubernetes e2e tests
Checklist: