gateway2: skip non-Gloo Gateways #10586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where we translate Gateways that do not belong to us. Signed-off-by: Shashank Ram <[email protected]>
|
Issues linked to changelog: |
conradhanson
approved these changes
Jan 30, 2025
|
Visit the preview URL for this PR (updated for commit 8fb0d69): https://gloo-edge--pr10586-shashankram-check-gw-gpxejclq.web.app (expires Thu, 06 Feb 2025 19:02:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
jenshu
reviewed
Jan 30, 2025
lgadban
approved these changes
Jan 30, 2025
jenshu
approved these changes
Jan 30, 2025
|
/kick-ci |
|
/kick |
|
@davidjumani is investigating a known flake that is failing on this PR. #10591 is an example of an empty PR that fails for the same reason, and @shashankram has been able to reproduce the failure locally (not on this branch). As a result, I am going to use admin permissions to merge this PR. (Update: Settings updated to disallow admin merge) |
sam-heilbron
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where we translate Gateways that do not belong to us.
Without this, we translate and update statuses on Gateways that do not belong to Gloo.