1.18.x mtls for xds in gg2 #10589
Merged
1.18.x mtls for xds in gg2 #10589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: David Jumani <[email protected]> Co-authored-by: Jenny Shu <[email protected]>
|
Issues linked to changelog: |
|
/kick |
jenshu
reviewed
Jan 31, 2025
sheidkamp
force-pushed
the
1.18.x-mtls-for-xds-in-gg2
branch
from
b55a68f to
1774762
Compare
jenshu
reviewed
Jan 31, 2025
Co-authored-by: Jenny Shu <[email protected]>
|
Issues linked to changelog: |
jenshu
approved these changes
Jan 31, 2025
davidjumani
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #10582
Also pulled in cli.Get which used in the new code but was not backported. The PR which introduced that method is large (45 files) and requires a solo-projects update, so the needed lines were manually added.
Note: this PR changes the behavior of gg2 when
global.glooMtls.enabled=true, which normally would not be allowed in an LTS branch or gated behind an environment variable. However, the current behavior is that if glooMtls is enabled communication between the gloo-proxy-gw and the control plane fails, so we would not be changing the behavior of anything that could be in use. Because of this, we can safely backport without additional gating.