Adding TestInstallation.AssertionsT

[ryanrolds]

Description

While looking into a flakey test I noticed that trying to check if the test failed in the AfterTest method wasn't working as expected; The Failed method was reporting false when there was a failure, preventing me from making a test-level cluster dump in the _test artifacts.

It turns out that TestInstallation.Assertions is created when the suite runs and uses the suite's testing.T. That leads to the issue and the framework calls it out in the log with testing.go:1577: test executed panic(nil) or runtime.Goexit: subtest may have called FailNow on a parent test.

This PR introduces a new method that takes the current testing.T and returns an appropriately scoped assertions provider. The previous method has been flagged in a way that VSC (and likely other IDEs) will call it out.

After we finish abating this issue, we should be able implement test-level dumps across our kubernetes/e2e tests. Making test failures easier to debug.

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works

[ryanrolds]

/kick-ci

[github-actions]

Visit the preview URL for this PR (updated for commit be68573):

https://gloo-edge--pr10600-rolds-assertiont-lervclao.web.app

_{(expires Fri, 14 Feb 2025 18:55:04 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 77c2b86e287749579b7ff9cadb81e099042ef677}

[jmcguire98]

LGTM, nice catch!

[ryanrolds]

/kick-ci