-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump istio, go-control-plane and k8s 1.32 deps #10611
bump istio, go-control-plane and k8s 1.32 deps #10611
Conversation
hmm some failure with kuztomize conflicting, will look more tomorrow. |
@@ -71,7 +68,6 @@ func ToEnvoyZipkinConfiguration(glooZipkinConfig *envoytracegloo.ZipkinConfig, c | |||
// strings to represent their kind. In the case of unexpected metadata format (eg, no gateways or multiple gateways), we | |||
// will log a warning and return a service.name string to help identify the issue. | |||
func GetGatewayNameFromParent(ctx context.Context, parent *gloov1.Listener) string { | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: extra whitespace changes bundled in to prs make them harder to read
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have standard auto-formatting that is checked in CI to avoid this stuff..
7ecb5b5
to
bca7821
Compare
Issues linked to changelog: |
6dc6758
to
5a413d4
Compare
This reverts commit 5e3e3f8.
@@ -434,6 +434,7 @@ | |||
|gloo.deployment.podSecurityContext.seccompProfile.localhostProfile|string||| | |||
|gloo.deployment.podSecurityContext.appArmorProfile.type|string||| | |||
|gloo.deployment.podSecurityContext.appArmorProfile.localhostProfile|string||| | |||
|gloo.deployment.podSecurityContext.seLinuxChangePolicy|string||| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we add a description here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. We don't have any description for the pod security context stuff and it likely is just a mirror of kuebrnetes fields.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to unblock because changelog is the only thing that has changed since the prior reviews.
Description
API changes
Code changes
Settings
collection must be a*Settings
collection now because only the pointer properly implementscontrollers.Object
which lets krt generate keys for it.Get
no longer needskrt.Key
and instead takes a raw string; this needed small updates in several placesSyncer().HasSynced()
,Collection
now embeds theSyncer
interface.Docs changes
Context
Interesting decisions
Testing steps
go test ./projects/gateway2/setup/ggv2setup_test.g
specifically will failthe destination rule/failover cases without the
perClientClusters == 0
checkand passes when adding it back.
Notes for reviewers
Checklist: