Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump istio, go-control-plane and k8s 1.32 deps #10611

Merged

Conversation

stevenctl
Copy link

@stevenctl stevenctl commented Feb 13, 2025

Description

  • Bump go-control-plane to latest, including the move to multi-module
  • Drop OpenCensus support since envoy dropped it
  • Bump istio/istio dep since it's tied to envoy go-control-plane
  • Work around the fact that newer istio brings async krt processing.

API changes

  • Drop OpenCensus support since envoy dropped it. We will now return "unsupported" for this config in our own API.

Code changes

  • Bump go modules istio and go-control-plane
  • Change filter_types gen to include the various envoy submodules. Some imports are duped but that should be ok.
  • Remove OpenCensus references that don't exist in newer go-control-plane
  • Add a check that prevents us from sending xds snapshot until we have processed per-client clusters. This will never send xDS if there are 0 upstreams, which likely never happens even in tests.
  • Bumping fsnotify would introduce a race in the sds filewatching test: Race when calling Add from a goroutine fsnotify/fsnotify#672
  • Made ggv2setup_test less flaky by ensuring endpoint pods are ready before we request xDS.
  • KRT changes:
    • Our Settings collection must be a *Settings collection now because only the pointer properly implements controllers.Object which lets krt generate keys for it.
    • krt Get no longer needs krt.Key and instead takes a raw string; this needed small updates in several places
    • Rather than calling Syncer().HasSynced(), Collection now embeds the Syncer interface.

Docs changes

Context

Interesting decisions

Testing steps

go test ./projects/gateway2/setup/ggv2setup_test.g specifically will fail
the destination rule/failover cases without the perClientClusters == 0 check
and passes when adding it back.

Notes for reviewers

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@stevenctl
Copy link
Author

hmm some failure with kuztomize conflicting, will look more tomorrow.

@@ -71,7 +68,6 @@ func ToEnvoyZipkinConfiguration(glooZipkinConfig *envoytracegloo.ZipkinConfig, c
// strings to represent their kind. In the case of unexpected metadata format (eg, no gateways or multiple gateways), we
// will log a warning and return a service.name string to help identify the issue.
func GetGatewayNameFromParent(ctx context.Context, parent *gloov1.Listener) string {

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extra whitespace changes bundled in to prs make them harder to read

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have standard auto-formatting that is checked in CI to avoid this stuff..

@stevenctl stevenctl changed the title bump istio and go-control-plane and hack around krt race bump istio, go-control-plane and k8s deps Feb 13, 2025
@stevenctl stevenctl changed the title bump istio, go-control-plane and k8s deps bump istio, go-control-plane and k8s 1.32 deps Feb 13, 2025
@stevenctl stevenctl force-pushed the stevenctl/bump-go-control-plane-istio branch 4 times, most recently from 7ecb5b5 to bca7821 Compare February 13, 2025 22:49
@solo-changelog-bot
Copy link

Issues linked to changelog:
kgateway-dev#10487

@stevenctl stevenctl requested a review from a team as a code owner February 13, 2025 23:12
@stevenctl stevenctl force-pushed the stevenctl/bump-go-control-plane-istio branch from 6dc6758 to 5a413d4 Compare February 13, 2025 23:43
@stevenctl stevenctl enabled auto-merge (squash) February 14, 2025 18:43
@@ -434,6 +434,7 @@
|gloo.deployment.podSecurityContext.seccompProfile.localhostProfile|string|||
|gloo.deployment.podSecurityContext.appArmorProfile.type|string|||
|gloo.deployment.podSecurityContext.appArmorProfile.localhostProfile|string|||
|gloo.deployment.podSecurityContext.seLinuxChangePolicy|string|||

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we add a description here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. We don't have any description for the pod security context stuff and it likely is just a mirror of kuebrnetes fields.

Copy link
Member

@Sodman Sodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock because changelog is the only thing that has changed since the prior reviews.

@stevenctl stevenctl merged commit 11a8d78 into solo-io:main Feb 17, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants