Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.18.x linter cleanup #10628

Merged
merged 2 commits into from
Feb 17, 2025
Merged

1.18.x linter cleanup #10628

merged 2 commits into from
Feb 17, 2025

Conversation

sheidkamp
Copy link

Description

Backport of #10625

@stevenctl
Copy link

/kick-ci

@stevenctl
Copy link

/kick

@arianaw66
Copy link

build-bot was already running. Sometimes it doesn't reflect it here- not sure why. But you can check in Cloud Build.

@sheidkamp
Copy link
Author

build-bot was already running. Sometimes it doesn't reflect it here- not sure why. But you can check in Cloud Build.

It happens when there are two commits in a short period of time, and I think specifically when there are changes that don't affect the build (in this case it was just moving the changelog).

@stevenctl
Copy link

It ran and failed from what I saw.

@soloio-bulldozer soloio-bulldozer bot merged commit 3b1b1b2 into v1.18.x Feb 17, 2025
18 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the 1.18.x-linter-cleanup branch February 17, 2025 19:51
@arianaw66
Copy link

It ran and failed from what I saw.

All the runs I see were cancelled, not failed, but I did see here it displayed as failed 🤷‍♀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants