Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update slack.go #10630

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/helpers/notify/slack.go
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,11 @@ func mustSendSlackMessage(data Payload) {
}

resp, err := netClient.Do(req)

fmt.Printf("\nslack response: %+v\n", resp)
fmt.Printf("\nslack StatusCode code: %v\n", resp.StatusCode)
fmt.Printf("\nslack response response: %+v\n", resp.Request)

if err != nil {
panic(err)
}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/nightly-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -604,6 +604,6 @@ jobs:
env:
PARENT_JOB_URL: https://github.com/solo-io/gloo/actions/runs/${{github.run_id}} # parent job hyperlink
PREAMBLE: ${{ steps.compute-preamble.outputs.preamble }} # text to hyperlink at start of slack message
SLACKBOT_BEARER: ${{ secrets.SLACKBOT_BEARER }}
SLACKBOT_BEARER: ${{ secrets.SLACK_BOT_TOKEN }}
run: |
go run .github/workflows/helpers/notify/slack.go '${{ toJSON(needs) }}'
3 changes: 1 addition & 2 deletions projects/gloo/pkg/translator/performance_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import (
"github.com/solo-io/go-utils/contextutils"

validationutils "github.com/solo-io/gloo/projects/gloo/pkg/utils/validation"
"github.com/solo-io/gloo/test/ginkgo/labels"

"github.com/onsi/gomega/types"
"github.com/solo-io/gloo/test/gomega/matchers"
Expand Down Expand Up @@ -43,7 +42,7 @@ import (
// More info on that machine can be found here: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources
// When developing new tests, users should manually run that action in order to test performance under the same parameters
// Results can then be found in the logs for that instance of the action
var _ = Describe("Translation - Benchmarking Tests", decorators.Performance, Label(labels.Performance), func() {
var _ = Describe("Translation - Benchmarking Tests", decorators.Performance, func() {
var (
ctrl *gomock.Controller
settings *v1.Settings
Expand Down
115 changes: 0 additions & 115 deletions test/e2e/README.md

This file was deleted.

Loading
Loading