Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix e2e tests: gateway tls listeners must specify tls #10659

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

puertomontt
Copy link

@puertomontt puertomontt commented Feb 25, 2025

Description

nightlies running GW API v1.0.0 were failing with :

The Gateway "<gateway created for test>" is invalid: spec.listeners: Invalid value: "array": tls must be specified for protocols ['HTTPS', 'TLS']

this PR adds the tls field for the listeners, which should be explicitly defined in the tests anyway, for clarity

API changes

Code changes

CI changes

Docs changes

Context

Interesting decisions

Testing steps

Notes for reviewers

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Copy link

Visit the preview URL for this PR (updated for commit a6a7322):

https://gloo-edge--pr10659-puertomontt-tls-test-yzhwqbcs.web.app

(expires Tue, 04 Mar 2025 16:22:42 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

@puertomontt puertomontt enabled auto-merge (squash) February 25, 2025 20:16
@puertomontt
Copy link
Author

/skip-ci temporary qemu issues

@puertomontt puertomontt merged commit a56a188 into main Feb 25, 2025
20 checks passed
@puertomontt puertomontt deleted the puertomontt/tls-tests branch February 25, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants