Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach jwt failure status to metadata #10662

Merged
merged 8 commits into from
Mar 3, 2025

Conversation

day0ops
Copy link

@day0ops day0ops commented Feb 26, 2025

Description

Adds the ability to inject the JWT failure status as part of dynamic metadata. Refer to docs failed_status_in_metadata.

API changes

Introduces a new field attach_failed_status_to_metadata to JWT provider to manage this.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@day0ops day0ops requested a review from a team as a code owner February 26, 2025 00:34
@day0ops day0ops self-assigned this Feb 26, 2025
@solo-changelog-bot
Copy link

Issues linked to changelog:
https://github.com/solo-io/solo-projects/issues/7837

Copy link

github-actions bot commented Feb 26, 2025

Visit the preview URL for this PR (updated for commit 4d31fa0):

https://gloo-edge--pr10662-attach-jwt-failure-s-cuyhhbj5.web.app

(expires Mon, 10 Mar 2025 04:57:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

Signed-off-by: day0ops <[email protected]>
Copy link

@sam-heilbron sam-heilbron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@day0ops
Copy link
Author

day0ops commented Mar 3, 2025

@sam-heilbron @jenshu ptal

@day0ops day0ops requested review from sam-heilbron and jenshu March 3, 2025 06:36
@soloio-bulldozer soloio-bulldozer bot merged commit a1a5d36 into main Mar 3, 2025
20 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the attach-jwt-failure-status-to-metadata branch March 3, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants